Use plugin parent POM #98
Conversation
|
|
||
| <name>Groovy Sandbox</name> | ||
| <description>Executes untrusted Groovy script safely</description> | ||
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> |
There was a problem hiding this comment.
Part of the parent POM as of jenkinsci/pom#257.
| <plugin> | ||
| <artifactId>maven-release-plugin</artifactId> | ||
| <configuration> | ||
| <releaseProfiles>release</releaseProfiles> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
The parent POM uses a profile named jenkins-release as of jenkinsci/pom#296.
| @@ -94,18 +89,12 @@ | |||
|
|
|||
| <profiles> | |||
| <profile> | |||
| <id>release</id> | |||
There was a problem hiding this comment.
The parent POM uses a profile named jenkins-release as of jenkinsci/pom#296.
| <execution> | ||
| <id>attach-sources</id> | ||
| <goals> | ||
| <goal>jar-no-fork</goal> | ||
| </goals> | ||
| </execution> |
There was a problem hiding this comment.
The parent POM's jenkins-release profile includes this logic as of jenkinsci/pom#296. However, the logic to attach the test sources is still necessary. I tested this by running mvn clean verify -Pjenkins-release and verified that the sources and test sources still got generated.
| <plugin> | ||
| <artifactId>maven-javadoc-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <id>attach-javadocs</id> | ||
| <goals> | ||
| <goal>jar</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
The parent POM's jenkins-release profile includes this logic as of jenkinsci/pom#296. I tested this by running mvn clean verify -Pjenkins-release and verified that the Javadoc still got generated.
|
Per dwnusbaum/groovy-cps#1 (comment) we actually want to use the plugin parent POM here. |
Updates the parent POM to the latest version as well as adding a
CODEOWNERSfile and updating the.gitignorefile to match the latest archetype. See self-review for details.CC @dwnusbaum