Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all Groovy test sources to Java #96

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Oct 21, 2022

The tests written in Groovy in this repository have often frustrated me. They cannot be run individually from my IDE when I need to debug a specific test, and I often run into subtle issues with incremental compilation and stub generation. I have not found Groovy's assert statement to be particularly helpful when debugging tests, and so in my opinion the main benefit of the Groovy sources was the readability improvement from using multi-line strings for Groovy scripts, which I am more than willing to give up to make the codebase more consistent and allow us to remove the dependency on gmavenplus.

Because so many lines needed semicolon insertions and other trivial modifications, Git's rename detection does not work and so the diff is not exactly reviewable. I verified that we are executing the same number of tests before and after the change to make sure that nothing got dropped by accident.

@jglick
Copy link
Member

jglick commented Oct 25, 2022

Git's rename detection does not work

Yeah Git tries to be clever but sometimes is not clever enough, or too clever. Mercurial lets you explicitly declare a file rename, which I have found more reliable and useful.

@dwnusbaum dwnusbaum merged commit a27b11f into jenkinsci:master Oct 25, 2022
@dwnusbaum dwnusbaum deleted the no-groovy-test-sources branch October 25, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants