Migrate all Groovy test sources to Java #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests written in Groovy in this repository have often frustrated me. They cannot be run individually from my IDE when I need to debug a specific test, and I often run into subtle issues with incremental compilation and stub generation. I have not found Groovy's
assert
statement to be particularly helpful when debugging tests, and so in my opinion the main benefit of the Groovy sources was the readability improvement from using multi-line strings for Groovy scripts, which I am more than willing to give up to make the codebase more consistent and allow us to remove the dependency ongmavenplus
.Because so many lines needed semicolon insertions and other trivial modifications, Git's rename detection does not work and so the diff is not exactly reviewable. I verified that we are executing the same number of tests before and after the change to make sure that nothing got dropped by accident.