Cleanup pom, add bom #243
Cleanup pom, add bom #243
Conversation
| @@ -50,15 +50,18 @@ | |||
| <revision>1.33.0</revision> | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <gitHubRepo>jenkinsci/github-plugin</gitHubRepo> | |||
| <jenkins.version>2.164.3</jenkins.version> | |||
| <jenkins.version>2.222.4</jenkins.version> | |||
There was a problem hiding this comment.
97% of users are on this version (https://stats.jenkins.io/pluginversions/github.html), and it's the minimum supported for new versions of bom currently.
also see https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
| @@ -33,12 +32,11 @@ | |||
|
|
|||
| @Test | |||
| public void nullName() { | |||
| ManuallyEnteredRepositorySource instance = Mockito.spy(new ManuallyEnteredRepositorySource("https://github.com/jenkinsci/jenkins")); | |||
| doReturn(null).when(instance).createName(Matchers.anyString()); | |||
| ManuallyEnteredRepositorySource instance = spy(new ManuallyEnteredRepositorySource("a")); | |||
There was a problem hiding this comment.
some weird mockito issue that only occurred when running all tests via CLI, couldn't reproduce in IDE or mvn test.
the test is checking nullName, so faking an impossible case didn't make sense anymore so I removed the mocking and the test works
| @@ -185,10 +185,6 @@ | |||
| <!-- Miscellaneous other checks. --> | |||
| <!-- See http://checkstyle.sf.net/config_misc.html --> | |||
| <module name="ArrayTypeStyle"/> | |||
| <module name="TodoComment"> | |||
There was a problem hiding this comment.
this is what is causing other PRs to fail CI currently
| @@ -32,6 +32,7 @@ | |||
|
|
|||
|
|
|||
| <module name="Checker"> | |||
| <property name="cacheFile" value="${checkstyle.cache.file}"/> | |||
There was a problem hiding this comment.
most changes in this file are just moving them around due to checkstyle update
@KostyaSha
if this is merged then #237 can be closed