Skip to content

More concise suggestion for GitHubAppCredentials.privateKey #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 11, 2023

Omitting the -out parameter since the form is prompting you to paste in text, not upload a file, so may as well just print to stdout.

Omitting -inform / -outform since they seem to be inferred.

Moving -in to the end to make it more convenient to paste this example and then just delete the example filename and replace with the real value.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jglick jglick requested a review from timja January 11, 2023 21:56
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MacOS Ventura:

$ openssl version
LibreSSL 3.3.6

Worked fine

@jglick jglick enabled auto-merge January 11, 2023 22:25
@jglick jglick merged commit addca9c into master Jan 11, 2023
@jglick jglick deleted the help-privateKey branch January 11, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants