Use instance-identity as a plugin rather than a module
#87
Conversation
|
Used my admin powers to replay the run with the |
| @@ -4,7 +4,8 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>4.40</version> | |||
| <version>4.44</version> | |||
| <relativePath /> | |||
There was a problem hiding this comment.
BTW
| <relativePath /> | |
| <relativePath/> |
The extra space is superfluous in XML; but traditional browser HTML parsers required it for XHTML IIRC; and when using maven-release-plugin the crappy XML rewriting tool always reinserts it. JEP-229 avoids the problem by not mechanically editing the version POM.
There was a problem hiding this comment.
The vast majority of our existing plugin POMs have the space so I was just following existing precedent. SortPom allows both conventions via the spaceBeforeCloseEmptyElement configuration option, which we've set to true in core to keep with existing precedent. Maybe someday when we run SortPom on more POMs that would be a good opportunity to clean this up globally.
Not needed for BOM in the short term, but a generally positive maintenance step IMHO. CC @jglick