[JENKINS-67466] Add timeout to JGit remote operations #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the JGit timeout implementation to prevent JGit operations from hanging indefinitely. The JGit timeout implementation has a very different behavior than the timeout implementation for command line git. The command line git implementation stops once the timeout has expired. The JGit timeout implementation stops after timeout period has completed with no traffic during the timeout period. See JENKINS-22400 for examples of other operations which still need timeout support. This does not add timeout support to JGit checkout because JGit checkout does not provide a timeout API.
MarkEWaite
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-67466 - Add timeout to JGit remote operations
Uses the JGit timeout implementation to prevent JGit operations from hanging indefinitely.
The JGit timeout implementation has a very different behavior than the timeout implementation for command line git. The command line git implementation stops once the timeout has expired. The JGit timeout implementation stops after timeout period has completed with no traffic during the timeout period.
This does not add timeout support to JGit checkout because JGit checkout does not provide a timeout API.
Checklist
Types of changes