Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused assertions and assert methods #794

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Dec 30, 2021

Remove unused assertions

Earlier splits of tests from one large file into smaller files did not consider that the tests in the smaller files did not need all the infrastructure that had been included when all the tests were in a single, larger file.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes

Types of changes

  • Test improvements

Earlier splits of tests from one large file into smaller files did not
consider that the tests in the smaller files did not need all the
infrastructure that had been included when all the tests were in a
single, larger file.
@github-actions github-actions bot added the test Automated test addition or improvement label Dec 30, 2021
@MarkEWaite MarkEWaite merged commit 236b0bf into jenkinsci:master Dec 30, 2021
@MarkEWaite MarkEWaite deleted the remove-unused-assertions branch December 30, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
1 participant