Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pom more consistent with git plugin #791

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Make pom more consistent with git plugin #791

merged 3 commits into from
Dec 28, 2021

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Dec 28, 2021 •
edited

Make pom more consistent with git plugin

Simplify maintenance of git client plugin by making its pom file more consistent with the git plugin pom file.

  • Define & use gitHubRepo property as is standard for repositories that support incremental delivery
  • Remove unnecessary hamcrest exclusion
  • Remove jsr305 exclusion

Checklist

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes

Types of changes

  • Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

@github-actions github-actions bot added the dependencies Dependency related change label Dec 28, 2021
@MarkEWaite
Define & use gitHubRepo property
288200b 
Consistent with instructions for incrementals

Consistent with git plugin
@MarkEWaite
Remove unnecessary hamcrest exclusion
7e902b1 
The junit version used in tests no longer requires the exclusion
@MarkEWaite
Remove jsr305 exclusion
b6d1d4f 
The maven hpi plugin no longer includes transitive dependencies of
dependencies into the hpi file.  Remove the exclusion for clarity.
@MarkEWaite MarkEWaite merged commit 2216bac into jenkinsci:master Dec 28, 2021
@MarkEWaite MarkEWaite deleted the sort-pom branch December 28, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Dependency related change
Projects
None yet
Milestone
No milestone
1 participant
@MarkEWaite