Rename the "Docker Host Certificate Authentication" credentials type to "X.509 Client Certificate" #79
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite initially introduced to provide authentication to a Docker host, this credentials format is actually independant from Docker itself, and can be used to authenticate to a TLS server using a X.509 client certificate. So this adjusts the label accordingly so that users can discover it in an easier way for other use cases than Docker (such as Kubernetes)
oleg-nenashev
approved these changes
Oct 6, 2019
|
@Vlatombe I will release that, but it might be useful to move it to the Credentials plugin later. It is a common functionality after all |
oleg-nenashev
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite initially introduced to provide authentication to a Docker host, this
credentials format is actually independant from Docker itself, and can be used
to authenticate to a TLS server using a X.509 client certificate.
So this adjusts the label accordingly so that users can discover it in an
easier way for other use cases than Docker (such as Kubernetes). See downstream usage in jenkinsci/kubernetes-plugin#520