[JENKINS-63761] Certificate upload correction #208
Merged
+330
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
reviewed
May 12, 2021
src/test/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImplTest.java
Outdated
Show resolved
Hide resolved
daniel-beck
approved these changes
May 12, 2021
|
I think we have typo in the bug number here in the subject - it is also wrong in the release notes https://github.com/jenkinsci/credentials-plugin/releases/tag/credentials-2.4 |
daniel-beck
changed the title
|
@saper thanks! (and thanks Daniel for the quick adjustment) |
|
Lol I spent far too long trying to integrate / fix a bug with certs in one of my plugins and gave up as I couldn’t figure out how to upload the cert... Good to know it wasn’t me being dumb, can’t remember where it was though |
6 tasks
basil
reviewed
Jul 1, 2024
| new Upload(getDivId(), uploadedKeystore), "complete"); | ||
| return FormValidation.ok("This endpoint is no longer required/supported due to the inlining of the file input. " + | ||
| "If you came to this endpoint due to another plugin, you will have to update that plugin to be compatible with Credentials Plugin 2.4+. " + | ||
| "It will be deleted soon."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira tickets: JENKINS-63761 and JENKINS-64542 (at least)
The second part about the validation was filed as a bug in the tracker: JENKINS-65616.
✔️ Both are resolved by putting the file input field "inline" inside the form instead of using a window. Then, by adding some magic from Jelly/hudson-behavior.js, we are able to trigger the validation at the correct moment.
Tested with:
Gifs of the behavior
2.253 Create
2.253 Update
2.292 Create
2.292 Update