[JENKINS-65398] terminology update #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
reviewed
Apr 19, 2021
src/main/java/com/cloudbees/plugins/credentials/CredentialsProviderFilter.java
Outdated
Show resolved
Hide resolved
jvz
reviewed
Apr 19, 2021
src/main/resources/com/cloudbees/plugins/credentials/BaseCredentials/help-scope.html
Outdated
Show resolved
Hide resolved
…ntials/help-scope.html
jvz
reviewed
Apr 19, 2021
...redentials/impl/CertificateCredentialsImpl/FileOnMasterKeyStoreSource/help-keyStoreFile.html
Outdated
Show resolved
Hide resolved
…ificateCredentialsImpl/FileOnMasterKeyStoreSource/help-keyStoreFile.html
jvz
approved these changes
Apr 19, 2021
daniel-beck
reviewed
Apr 19, 2021
| @@ -52,7 +52,7 @@ While the Credentials API plugin provides a default _internal_ credentials store | |||
| If you are using the _internal_ credentials store to store *high value* credentials then you will need to lock down your Jenkins configuration: | |||
|
|
|||
| * Apply all of the recommendations from the https://wiki.jenkins.io/display/JENKINS/Securing+Jenkins[Securing Jenkins] wiki page. | |||
| * No builds on the master (ideally zero executors) | |||
| * No builds on the controller (ideally zero executors) | |||
There was a problem hiding this comment.
Still undefined due to lack of followup for the last 8 months.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing offending terminology such as master,slave or whitelist/blacklist as part of JENKINS-65398
I tried to update whitelist/ black list with the context, feel free to tell me if it's not accurate.