Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-65333] Sort credentials entries only for UI #194

Merged
merged 2 commits into from Apr 9, 2021
Merged

[JENKINS-65333] Sort credentials entries only for UI #194

merged 2 commits into from Apr 9, 2021

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Apr 9, 2021 •
edited

This moves the sorting logic from CredentialsProvider#lookupCredentials to CredentialsProvider#getCredentialIds, so that it happens after applying matchers, and only when being pulled in a UI.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jvz jvz merged commit 92abc7d into jenkinsci:master Apr 9, 2021
@Vlatombe Vlatombe deleted the JENKINS-65333 branch April 9, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtnord jtnord jtnord approved these changes

@jvz jvz jvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Vlatombe @jtnord @jvz