New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to reload secrets from properties file with JCasC reload #1556
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
============================================
- Coverage 81.02% 81.01% -0.01%
+ Complexity 811 810 -1
============================================
Files 66 66
Lines 2371 2370 -1
Branches 329 328 -1
============================================
- Hits 1921 1920 -1
Misses 349 349
Partials 101 101
|
plugin/src/main/java/io/jenkins/plugins/casc/impl/secrets/PropertiesSecretSource.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/casc/impl/secrets/PropertiesSecretSource.java
Outdated
Show resolved
Hide resolved
6bc5d12
to
f7dd5f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
plugin/src/main/java/io/jenkins/plugins/casc/impl/secrets/PropertiesSecretSource.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/casc/impl/secrets/PropertiesSecretSource.java
Outdated
Show resolved
Hide resolved
f7dd5f4
to
35d3e7f
Compare
@tempora-mutantur any chance of a test that validates that secrets are reloaded when the properties change? codecov is complaining of a lack of test coverage here |
@timja The lack of test coverage is actually due to file exist if condition and catching exception which is kinda 🤷♂️ |
well I assume we aren't testing that you can change the file and reload and it works since that didn't work before. having the secret source not fail when the file is missing having a test wouldn't be a bad thing, not that I'm convinced it's a good feature, personally I would rather it just fails but maybe people rely on that now. not a blocker |
I agree with you on the need for a properties reload test would be great. Just correcting as to why codecov was complaining since codecov has changed the detail link to point to their homepage and not the pull request link. |
Thanks, codecov is still complaining about missing coverage on no properties file but meh! |
T@tempora-mutantur Is there a documentation update please? I'd like to understand how to use this feature. Thanks. |
This is not something that is user facing @martinda next time the configure is called JCASC will read the properties again using the init method. configuration-as-code-plugin/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java Line 733 in ec812a8
|
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.