Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bouncycastle to 1.64 #25

Merged
merged 3 commits into from Jan 2, 2020
Merged

Update bouncycastle to 1.64 #25

merged 3 commits into from Jan 2, 2020

Conversation

res0nance
Copy link
Contributor

jvz
jvz approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have no idea about API changes here.

oleg-nenashev
oleg-nenashev approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Better to stay up to date. There are few breaking changes in 1.60..1.63 according to https://www.bouncycastle.org/releasenotes.html

* TLS: Removed support for EC point compression.
* TLS: Removed support for record compression.

I cannot elaborate impact of these changes on Jenkins users, but it should be fairly minor. Likely, it would impact only legacy infrastructures with deprecated TLS versions

@res0nance
Copy link
Contributor Author

Bumping to 1.64 due to CVE-2019-17359

@res0nance res0nance changed the title Update bouncycastle to 1.63 Update bouncycastle to 1.64 Dec 28, 2019
@oleg-nenashev
Copy link
Member

@jeffret-b would you be available to cut a release? No urgency

@jeffret-b
Copy link
Contributor

Looks good and it's definitely good to stay current. I'll see if I can get a release out today.

@jeffret-b jeffret-b merged commit 121e58b into jenkinsci:master Jan 2, 2020
@jeffret-b jeffret-b mentioned this pull request Jan 2, 2020
Closed
@res0nance res0nance deleted the update-bouncycastle branch January 3, 2020 04:02
@jeffret-b
Copy link
Contributor

Bumping to 1.64 due to CVE-2019-17359

Just making a note here that CVE-2019-17359 doesn't apply to us. It was introduced in in 1.63, which we skipped over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvz jvz jvz approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@jeffret-b jeffret-b jeffret-b approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
4 participants
@res0nance @oleg-nenashev @jeffret-b @jvz