Skip to content

Add support-core to the managed set #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 1, 2022
Merged

Conversation

PierreBtz
Copy link
Contributor

The support core plugin is added to to the BOM, as well as the metrics plugin which is one of its dependencies.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sorry, something went wrong.

@timja timja added the enhancement New feature or request label Sep 10, 2021
Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@timja timja enabled auto-merge (squash) September 10, 2021 14:01
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent failures in org.jenkinsci.plugins.workflow.libs.LibraryMemoryTest#loaderReleased. These can be reproduced locally by running:

PLUGINS=workflow-cps-global-lib TEST=org.jenkinsci.plugins.workflow.libs.LibraryMemoryTest\#loaderReleased bash local-test.sh

Happy hunting!

@basil basil disabled auto-merge September 14, 2021 15:34
@jglick
Copy link
Member

jglick commented Dec 3, 2021

Smelling like a genuine bug either in support-core or Pipeline:

Apparent soft references to org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxResolvingClassLoader@5c4b2eab: {org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxResolvingClassLoader@5c4b2eab=private static final java.util.logging.LogManager java.util.logging.LogManager.manager->
java.util.logging.LogManager@12b1711f-rootLogger->
java.util.logging.LogManager$RootLogger@3ee2b483-handlers->
java.util.concurrent.CopyOnWriteArrayList@58abc1f8-array->
[Ljava.lang.Object;@21b44262-[1]->
com.cloudbees.jenkins.support.SupportLogHandler@6cdc4d57-records->
[Ljava.util.logging.LogRecord;@51f1a124-[10]->
java.util.logging.LogRecord@758530e9-parameters->
[Ljava.lang.Object;@219775d9-[0]->
org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxResolvingClassLoader@5c4b2eab}

@basil basil enabled auto-merge (squash) March 1, 2022 19:54
@basil basil disabled auto-merge March 1, 2022 20:05
@basil basil enabled auto-merge (squash) March 1, 2022 20:07
@basil basil disabled auto-merge March 1, 2022 20:32
@jglick jglick changed the title Add Support Core to the managed set Add support-core to the managed set Mar 1, 2022
@jglick jglick enabled auto-merge (squash) March 1, 2022 20:54
@jglick jglick merged commit 2add6f7 into jenkinsci:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants