Skip to content

Exclude git client plugin test_list_branches failures #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Sep 2, 2021

Exclude bom 2.249.x test failures from git client plugin

Git client plugin 3.6.0 does not include jenkinsci/git-client-plugin#675 that resolves a test failure with command line git 2.33 and later. Git client plugin 3.7.0 and later include that fix.

Git client plugin 3.6.0 also does not include the change for git LFS execution on ci.jenkins.io.

This exclusion will no longer be needed when the bom drops support for 2.249.x.

Fixes #638.

Git client plugin 3.6.0 does not include
jenkinsci/git-client-plugin#675 that resolves a
test failure with command line git 2.33 and later.  Git client plugin
3.7.0 and later include that fix.

Git client plugin 3.6.0 also does not include the change for git LFS
execution on ci.jenkins.io.

This exclusion will no longer be needed when the bom drops support for
2.249.x.
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #638?

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Surefire exclusions won't allow exclusion of an
individual test.

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
auto-merge was automatically disabled September 2, 2021 11:48

Head branch was pushed to by a user without write access

@jglick jglick enabled auto-merge September 2, 2021 11:49
@jglick jglick merged commit 232f4ff into jenkinsci:master Sep 2, 2021
@MarkEWaite MarkEWaite deleted the exclude-git-client-3.6.0-test-failure-on-cli-git-2.33 branch September 2, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CliGitAPIImplTest.test_list_branches (& JGitAPIImplTest) failing
3 participants