Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git plugin 5.0.0 and git client plugin 4.0.0 #1663

Merged
merged 1 commit into from Dec 30, 2022
Merged

Use git plugin 5.0.0 and git client plugin 4.0.0 #1663

merged 1 commit into from Dec 30, 2022

Conversation

MarkEWaite
Copy link
Contributor

Use git plugin 5.0.0 and git client plugin 4.0.0

Changelogs for releases:

Previously evaluated in:

Pins git plugin 4.14.3 for Jenkins 2.346.x and older because git plugin 5.0.0 requires Java 11 and Jenkins 2.361.4 or newer.

Pins git client plugin 3.13.1 for Jenkins 2.346.x and older because git client plugin 4.0.0 requires Java 11 and Jenkins 2.361.4 or newer.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Use git plugin 5.0.0 and git client plugin 4.0.0
0d3725f 
Pins git plugin 4.14.3 for Jenkins 2.346.x and older because git plugin
5.0.0 requires Java 11 and Jenkins 2.361.4 or newer.

Pins git client plugin 3.13.1 for Jenkins 2.346.x and older because git
client plugin 4.0.0 requires Java 11 and Jenkins 2.361.4 or newer.

Previously evaluated in:

* jenkinsci#1619
* jenkinsci#1625

Changelogs for releases:

* https://github.com/jenkinsci/git-client-plugin/releases/tag/git-client-4.0.0
* https://github.com/jenkinsci/git-plugin/releases/tag/git-5.0.0
@MarkEWaite MarkEWaite added the developer Pull requests that merits a release for plugin developers label Dec 30, 2022
@MarkEWaite
Copy link
Contributor Author

@timja or @jglick is it OK that I merge my own pull request or is it better that I wait for another reviewer to merge it?

I've labeled this pull request so that it will generate a new BOM release. Let me know if that is not desirable.

@jglick jglick merged commit 092b898 into jenkinsci:master Dec 30, 2022
@MarkEWaite MarkEWaite deleted the add-symbols-git-plugin-upgrade branch December 30, 2022 16:34
@timja
Copy link
Member

timja commented Dec 30, 2022

@timja or @jglick is it OK that I merge my own pull request or is it better that I wait for another reviewer to merge it?

Yes go for it use your judgement for when something needs review, dependency updates are absolutely fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
developer Pull requests that merits a release for plugin developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarkEWaite @timja @jglick