Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin git client plugin 3.12.4 for Jenkins 2.332.x tests #1643

Merged

Conversation

MarkEWaite
Copy link
Contributor

Pin git client plugin 3.12.4 for Jenkins 2.332.x tests

https://issues.jenkins.io/browse/JENKINS-70174 notes that the git client plugin automated tests failed when using a shallow clone (depth == 1) of a single branch. The issue was fixed for Jenkins 2.346.3 and newer with the release of git client plugin 3.13.1. This release is a backport of that fix.

No plugin functionality was changed in this release. It changes the automated tests when run from a shallow clone (depth == 1) of a single branch.

#1613 is the key consumer in the plugin bill of materials.

jenkinsci/plugin-compat-tester#382 is the key consumer in the plugin compatibility tester.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@olamy and @jglick I believe we'll need a release of the bom that includes this update.

https://issues.jenkins.io/browse/JENKINS-70174 notes that the git client
plugin automated tests failed when using a shallow clone (depth == 1)
of a single branch.  The issue was fixed for Jenkins 2.346.3 and newer
with the release of git client plugin 3.13.1.  This release is a backport
of that fix.

No plugin functionality was changed in this release.  It changes the
automated tests when run from a shallow clone (depth == 1) of a single
branch.

jenkinsci#1613 is the key consumer in the
plugin bill of materials.

jenkinsci/plugin-compat-tester#382 is the key
consumer in the plugin compatibility tester.
@MarkEWaite MarkEWaite added dependencies Pull requests that update a dependency file enhancement New feature or request and removed dependencies Pull requests that update a dependency file labels Dec 13, 2022
@MarkEWaite
Copy link
Contributor Author

@jglick I've labelled this pull request as enhancement so that it will result in a new release of the bom. I think the other updates since the last BOM release justify a new release. Those updates include:

If you don't feel that those pull requests justify a release, could you remove the enhancement label from this pull request so that it does not trigger the release?

@jglick jglick merged commit 0071fa4 into jenkinsci:master Dec 14, 2022
@MarkEWaite MarkEWaite deleted the pin-git-client-3.12.4-for-2.332.x branch December 14, 2022 00:14
@timja
Copy link
Member

timja commented Dec 14, 2022

release whenever you feel like it @MarkEWaite. Generally we release when either there's something we want out there or after a few changes are merged (which sometimes builds up a bit if we forget to trigger a release)

@jglick
Copy link
Member

jglick commented Dec 14, 2022

Exactly. We set up CD to make it painless to release any time we even think it might be useful, and jenkinsci/archetypes#488 so that most plugin maintainers should not care anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants