Clarify the purpose of this repository #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are welcome for the timely response @daniel-beck |
jglick
reviewed
Dec 12, 2022
Comment on lines
+106
to
+110
| While different people have different definitions as to what constitutes "critical", some common definitions are: | ||
|
|
||
| - In the default list of suggested plugins | ||
| - In the list of the top 100 (or 250) plugins | ||
| - In the list of plugins with more than 10,000 (or 1,000) users |
There was a problem hiding this comment.
FWIW https://plugins.jenkins.io/file-parameters/ has ~2500 installations (wow!) but a key reason I added it was that any regressions in it might point to subtle problems in Pipeline overall. Not sure if we need to bother with such discussions here though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1627.