Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant 2.332.x credentials dependency #1568

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Remove redundant 2.332.x credentials dependency #1568

merged 3 commits into from
Nov 12, 2022

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Nov 9, 2022 •
edited

Remove redundant 2.332.x credentials dependency

A credentials dependency was declared twice in the 2.332.x pom. One of the two dependencies declared the wrong version.
Remove the incorrect dependency.

#1564 (comment)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Remove redundant credential pin in 2.332.x
9ccab4c 
No need to duplicate the pin in the 2.332.x pom when it is already
pinned with that version in the 2.346.x pom
@MarkEWaite MarkEWaite added the dependencies Pull requests that update a dependency file label Nov 9, 2022
@jglick jglick added chore Reduces future maintenance and removed dependencies Pull requests that update a dependency file labels Nov 9, 2022
jglick
jglick approved these changes Nov 9, 2022
View reviewed changes
bom-2.332.x/pom.xml Outdated
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>credentials</artifactId>
<version>1087.1089.v2f1b_9a_b_040e4</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, pinned in #1065 but why?

I guess fine if CI passes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've since learned that it was pinned at this version because that is the newest version supported on the 2.332.x line. This will need to remain.

@jglick
Copy link
Member

jglick commented Nov 11, 2022 

Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.35:validate-hpi (default-validate-hpi) on project sample: Dependency org.jenkins-ci.plugins:credentials:jar:1143.vb_e8b_b_ceee347 requires Jenkins 2.340 or higher.

While you are here, we need to fix #1569.

@MarkEWaite
Merge branch 'master' into remove-redundant-pin
2c124ad
@MarkEWaite
Restore the 2.332.x dependency I mistakenly deleted
acfe981 
Credentials 1087.1089.v2f1b_9a_b_040e4 is the newest version supported on 2.332.1
@MarkEWaite MarkEWaite changed the title Remove duplicated credentials in 2.332.x Remove duplicated credentials dependency in 2.332.x Nov 12, 2022
@MarkEWaite MarkEWaite changed the title Remove duplicated credentials dependency in 2.332.x Remove redundant 2.332.x credentials dependencies Nov 12, 2022
@MarkEWaite MarkEWaite changed the title Remove redundant 2.332.x credentials dependencies Remove redundant 2.332.x credentials dependency Nov 12, 2022
@MarkEWaite MarkEWaite merged commit ba19636 into jenkinsci:master Nov 12, 2022
@MarkEWaite MarkEWaite deleted the remove-redundant-pin branch November 12, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
chore Reduces future maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkEWaite @jglick