Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use credentials 1189.vf61b_a_5e2f62e #1564

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

MarkEWaite
Copy link
Contributor

Use credentials 1189.vf61b_a_5e2f62e

  • Bump credentials in /bom-weekly
  • Pin credentials plugin for 2.332.x and 2.346.x

Includes #1465 and pins credenitals plugin at an older release.

Once this is merged, it should unblock #1479 and allow the Jenkins version in bom-weekly to increment from 2.371 to 2.376 or 2.377.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

dependabot bot and others added 3 commits September 21, 2022 22:35
Bumps [credentials](https://github.com/jenkinsci/credentials-plugin) from 1143.vb_e8b_b_ceee347 to 1189.vf61b_a_5e2f62e.
- [Release notes](https://github.com/jenkinsci/credentials-plugin/releases)
- [Changelog](https://github.com/jenkinsci/credentials-plugin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jenkinsci/credentials-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:credentials
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@MarkEWaite
Copy link
Contributor Author

@timja or @jglick could you merge this and the others that are passing in hopes that we can unblock #1479

@timja timja merged commit 16dacd7 into jenkinsci:master Nov 9, 2022
@timja
Copy link
Member

timja commented Nov 9, 2022

You're welcome to commit access if you want it. Thanks for sorting this

@MarkEWaite MarkEWaite deleted the use-latest-credentials-release branch November 9, 2022 13:09
@MarkEWaite
Copy link
Contributor Author

That would be very nice. I'm not sure that I can be much help, but if I can have commit access, I may be able to help sometimes.

@timja
Copy link
Member

timja commented Nov 9, 2022

done

Comment on lines +28 to +32
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>credentials</artifactId>
<version>1143.vb_e8b_b_ceee347</version>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? It should be inheriting the version from the 2.346.x line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the education. I had forgotten that the 2.346.x line is taken into the 2.332.x line. I'll remove that wasted addition in a later pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jglick jglick added the dependencies Pull requests that update a dependency file label Nov 9, 2022
@jglick
Copy link
Member

jglick commented Nov 9, 2022

@MarkEWaite MarkEWaite added the java Pull requests that update Java code label Nov 9, 2022
@MarkEWaite
Copy link
Contributor Author

Also jenkins-infra/interesting-category-action#1

I am not sure on this one. Earlier merges of credentials plugin updates were labeled with dependencies and java. This is not much different than those. I added java. What label should have been added?

@jglick
Copy link
Member

jglick commented Nov 9, 2022

dependencies is what is needed. java does not matter, that is just added automatically by Dependabot also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants