You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good in general. The only issue so far is with antisamy-markup-formatter because jenkinsci/antisamy-markup-formatter-plugin#65 has not yet been released and so it does not support incrementals:
[2022-11-03T19:50:29.619Z] [ERROR] Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.33:resolve-test-dependencies (default-resolve-test-dependencies) on project antisamy-markup-formatter: Unable to resolve dependencies: Could not resolve dependencies for project org.jenkins-ci.plugins:antisamy-markup-formatter:hpi:2.7: Could not find artifact org.jenkins-ci.plugins.workflow:workflow-cps:jar:3513.v1b_01482f7077 in repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/) -> [Help 1]
workflow-cps itself has passed against the latest weekly, but hasn't run against 2.332.x yet as far as I can tell.
The GitHub check mentioning that caffeine-api failed is just a reporting bug. The only plugin that failed is indeed antisamy-markup-formatter in the weekly branch. I will update it and remove failFast = false and then I think all of the downstream stuff is ready to be merged.
dwnusbaum
changed the title
Test changes related to converting workflow-cps into a multi-module project
Update workflow-cps, antisamy-markup-formatter, and the PCT
Nov 4, 2022
dependenciesPull requests that update a dependency file
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dwnusbaum
changed the title
Originally filed to test jenkinsci/workflow-cps-plugin#612 and jenkinsci/plugin-compat-tester#383, but now it updates everything related to those PRs.