Remove git client plugin test exclusions #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `git-plugin.version` from 4.11.5 to 4.13.0. Updates `git` from 4.11.5 to 4.13.0 - [Release notes](https://github.com/jenkinsci/git-plugin/releases) - [Changelog](https://github.com/jenkinsci/git-plugin/blob/master/CHANGELOG.adoc) - [Commits](jenkinsci/git-plugin@git-4.11.5...git-4.13.0) Updates `git` from 4.11.5 to 4.13.0 - [Release notes](https://github.com/jenkinsci/git-plugin/releases) - [Changelog](https://github.com/jenkinsci/git-plugin/blob/master/CHANGELOG.adoc) - [Commits](jenkinsci/git-plugin@git-4.11.5...git-4.13.0) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:git dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jenkins-ci.plugins:git:tests dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [git-client](https://github.com/jenkinsci/git-client-plugin) from 3.11.0 to 3.13.0. - [Release notes](https://github.com/jenkinsci/git-client-plugin/releases) - [Commits](jenkinsci/git-client-plugin@git-client-3.11.0...git-client-3.13.0) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:git-client dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Command line git 2.38.1 and backports to earlier versions now exclude submodule clones from a file:// URL. The tests in the git client plugin rely on submodule clones from a file:// URL for some of the tests. Git client plugin 2.13.0 includes test changes to allow the tests to run on git 2.38.1 successfully. These exclusions should not be needed any longer. See jenkinsci#1484 for the original addition of the exclusions. jenkinsci/git-client-plugin#920 (comment) reminds us to remove the exclusion. jenkinsci/git-client-plugin#923 implements the fix in the tests to allow file:// protocol clones during the submodule operations in the tests.
…' and 'dependabot/maven/bom-weekly/org.jenkins-ci.plugins-git-client-3.13.0' into remove-git-client-test-exclusions
|
This should fix it #1543 |
Thanks very much! Since git client plugin 2.13.0 requires Jenkins 2.346.3 as its minimum version, won't the earlier git client plugin version still need to be pinned for 2.332.x? |
jglick
approved these changes
Nov 1, 2022
| @@ -13,7 +13,7 @@ | |||
| <configuration-as-code-plugin.version>1559.v38a_b_2e3b_6b_b_7</configuration-as-code-plugin.version> | |||
| <data-tables-api.version>1.12.1-4</data-tables-api.version> | |||
| <forensics-api.version>1.15.1</forensics-api.version> | |||
| <git-plugin.version>4.11.5</git-plugin.version> | |||
| <git-plugin.version>4.13.0</git-plugin.version> | |||
| @@ -343,7 +343,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>git-client</artifactId> | |||
| <version>3.11.0</version> | |||
| <version>3.13.0</version> | |||
| @@ -12,9 +12,3 @@ org.jenkinsci.plugins.gitclient.FilePermissionsTest | |||
|
|
|||
| # TODO tends to run out of memory | |||
| org.jenkinsci.plugins.pipeline.modeldefinition.TriggersTest | |||
|
|
|||
| # TODO https://github.com/jenkinsci/git-client-plugin/pull/920 | |||
There was a problem hiding this comment.
picking up jenkinsci/git-client-plugin#920
…_b_7c8fd5fde in /bom-2.332.x (jenkinsci#1512)" This reverts commit 41c4799.
auto-merge was automatically disabled
November 2, 2022 18:02
Head branch was pushed to by a user without write access
|
I do not think you want to merge #1543 in here when that PR does not yet work! |
I was hoping that the single 2.319.x failure displayed previously in this pull request was an indicator that all that was needed was to drop 2.319.x. Unfortunately, experiment failed. I'll revert that change and look at ways to pin the versions on 2.332.x and 2.319.x. |
|
Maybe just sit tight—I am trying to fix #1543. |
|
Merged, so just try merging in master now. |
jglick
reviewed
Nov 3, 2022
Fixes the submodule test failures with CLI git 2.38.1 See https://github.com/jenkinsci/git-client-plugin/releases/tag/git-client-3.12.2
auto-merge was automatically disabled
November 3, 2022 17:58
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove git client plugin test exclusions
Command line git 2.38.1 and backports to earlier versions now exclude submodule clones from a file:// URL. The tests in the git client plugin rely on submodule clones from a file:// URL for some of the tests. Git client plugin 2.13.0 includes test changes to allow the tests to run on git 2.38.1 successfully. These exclusions should not be needed any longer.
See #1484 for the original addition of the exclusions.
jenkinsci/git-client-plugin#920 (comment) reminds us to remove the exclusion.
jenkinsci/git-client-plugin#923 implements the fix in the tests to allow file:// protocol clones during the submodule operations in the tests.