Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jenkins.version from 2.371 to 2.377 for bom-weekly #1479

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 5, 2022

Bump jenkins.version from 2.371 to 2.377 for bom-weekly

Report

Source:
	✔ [jenkins] Get Last jenkins Weekly Version(jenkins)


Condition:
	✔ [jenkins] Test if Jenkins stable published(maven)

Target:
	✔ [jenkins] Update Jenkins version(shell)

Changelog

Click to expand
Jenkins changelog is available at: https://www.jenkins.io/changelog/#v2.377


Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

…/b...

... om/updatecli/update-jenkins.ps1 weekly 2.372"

Made with ❤️️ by updatecli
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 5, 2022
@github-actions github-actions bot enabled auto-merge (squash) October 5, 2022 01:12
…/b...

... om/updatecli/update-jenkins.ps1 weekly 2.373"

Made with ❤️️ by updatecli
…/b...

... om/updatecli/update-jenkins.ps1 weekly 2.374"

Made with ❤️️ by updatecli
@github-actions github-actions bot changed the title Bump jenkins.version from 2.371 to 2.372 for bom-weekly Bump jenkins.version from 2.371 to 2.374 for bom-weekly Oct 19, 2022
…/b...

... om/updatecli/update-jenkins.ps1 weekly 2.375"

Made with ❤️️ by updatecli
@github-actions github-actions bot changed the title Bump jenkins.version from 2.371 to 2.374 for bom-weekly Bump jenkins.version from 2.371 to 2.375 for bom-weekly Oct 25, 2022
jglick and others added 3 commits October 26, 2022 23:03
…/b...

... om/updatecli/update-jenkins.ps1 weekly 2.376"

Made with ❤️️ by updatecli
@github-actions github-actions bot changed the title Bump jenkins.version from 2.371 to 2.375 for bom-weekly Bump jenkins.version from 2.371 to 2.376 for bom-weekly Nov 2, 2022
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Nov 8, 2022
…/b...

... om/updatecli/update-jenkins.ps1 weekly 2.377"

Made with ❤️️ by updatecli
@github-actions github-actions bot changed the title Bump jenkins.version from 2.371 to 2.376 for bom-weekly Bump jenkins.version from 2.371 to 2.377 for bom-weekly Nov 8, 2022
@jglick
Copy link
Member

jglick commented Nov 11, 2022

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project gitlab-plugin: Compilation failure: Compilation failure: 
/home/jenkins/agent/workspace/Tools_bom_PR-1479/pct-work/gitlab-plugin/src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/push/OpenMergeRequestPushHookTriggerHandler.java:[62,78] error: incompatible types: Collection<Trigger<?>> cannot be converted to Collection<Trigger>
/home/jenkins/agent/workspace/Tools_bom_PR-1479/pct-work/gitlab-plugin/src/main/java/com/dabsquared/gitlabjenkins/GitLabPushTrigger.java:[555,68] error: incompatible types: Collection<Trigger<?>> cannot be converted to Collection<Trigger>

@jglick
Copy link
Member

jglick commented Nov 11, 2022

Probably related somehow to jenkinsci/jenkins#7131 though I am not quite sure how.

@MarkEWaite
Copy link
Contributor

I can see the failure when I attempt to compile the gitlab plugin with JDK 17 and Jenkins 2.375. I'm currently one of the maintainers of the gitlab plugin. I'll try to prepare a new release of the gitlab plugin that fixes the compile issue and includes JDK 17 and Jenkins 2.375 in the tests run by the Jenkinsfile.

@jglick
Copy link
Member

jglick commented Nov 11, 2022

I am working on it already.

@jglick
Copy link
Member

jglick commented Nov 11, 2022

The real problem here is that a compilation error against a newer core even matters to begin with. PCT used to compile against the plugin’s declared baseline and only run tests against alternate versions. I think this got broken in #1336 (CC @basil); could probably be fixed by enhancing PCT to allow you to separately declare Maven properties to be used for the compile command vs. for the test command. As it stands, passing -Djenkins.version in both commands, there is no advantage to even separating these commands at all, so we get the downsides (test runs do not use the same bytecode as the current plugin release, which matters in some weird binary compatibility cases; and PCT runs are vulnerable to source incompatibility issues like this one) without the upside (simplified and faster operation that could work better for multimodule repositories). Related: jenkinsci/maven-hpi-plugin#336 (comment) jenkinsci/plugin-compat-tester#384 (comment)

@jglick jglick marked this pull request as draft November 11, 2022 17:33
failFast Outdated Show resolved Hide resolved
@MarkEWaite MarkEWaite marked this pull request as ready for review November 12, 2022 15:52
@MarkEWaite MarkEWaite merged commit 5d15088 into master Nov 12, 2022
@MarkEWaite MarkEWaite deleted the updatecli_b6d3cd013bfb6d5702893bce83b5d78a278ac918b95b4572d0917e539ae7bf62 branch November 12, 2022 17:19
@jglick jglick mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants