Skip to content

Bump jenkins.version from 2.346.1 to 2.346.3 for bom-2.346.x #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2022

Bump jenkins.version from 2.346.1 to 2.346.3 for bom-2.346.x

Report

Source:
	✔ [jenkins] Get last Jenkins stable version(githubrelease)


Condition:
	✔ [jenkins] Test if Jenkins stable published(maven)

Target:
	✔ [jenkins] Update Jenkins version(shell)

Changelog

Click to expand

Release published on the 2022-08-10 09:36:15 +0000 UTC at the url https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.346.3

# Jenkins 2.346.3

We're excited to announce the release of Jenkins 2.346.3 🎉 

## Changelog and upgrade guide

See the [changelog](https://www.jenkins.io/changelog-stable/#v2.346.3) and [upgrade guide](https://www.jenkins.io/doc/upgrade-guide/2.346/#upgrading-to-jenkins-lts-2-346-3) to learn about breaking changes and other considerations when updating.

## Reporting issues
If you find an issue with this release, please file an issue on [Jira](https://issues.jenkins.io/), otherwise use the [forums](https://community.jenkins.io/) if you're unsure whether you encounter an issue or not.

Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

…/b...

... om/updatecli/update-jenkins.ps1 2.346.x 2.346.2"

Made with ❤️️ by updatecli
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 9, 2022
@github-actions github-actions bot enabled auto-merge (squash) August 9, 2022 19:12
@basil basil disabled auto-merge August 9, 2022 20:03
@basil
Copy link
Member

basil commented Aug 9, 2022

Is this not premature since 2.361.1 won't ship until September 7?

@github-actions github-actions bot enabled auto-merge (squash) August 9, 2022 20:05
@jetersen
Copy link
Member

jetersen commented Aug 9, 2022

This version is only used for testing BOM against 2.346.x and due to constraints we are only really testing 2.319.x and weekly.

Hence my wish to run CI for all on GitHub #1350

@jetersen
Copy link
Member

jetersen commented Aug 9, 2022

You could argue that did not need to merge #1387

@basil
Copy link
Member

basil commented Aug 9, 2022

You could argue that did not need to merge #1387

I think I agree with this.

@basil
Copy link
Member

basil commented Aug 9, 2022

The difference is that merging #1387 early doesn't have any practical side effects as far as I can tell (nobody would be using the bom-2.361 artifact ahead of the LTS release), but merging this PR "early" would have some negative consequences in that the next release of bom-2.346 would start pushing consumers to a .2 contra the documentation.

@jetersen
Copy link
Member

jetersen commented Aug 9, 2022

effectively this is still 2.346.x and nobody is being pushed to 2.346.2. This is used by sample plugin internally in the bom project not exposed to anybody.

@jetersen
Copy link
Member

jetersen commented Aug 9, 2022

Feel free to disable auto merge if you disagree.

@basil
Copy link
Member

basil commented Aug 9, 2022

Does this not enable the published bom-2.346 artifact to now contain plugins that depend on 2.346.2, which we don't want to encourage for another month? I do not feel strongly either way.

@jetersen
Copy link
Member

jetersen commented Aug 9, 2022

Yes potentially this would pick up anyone pointing to .2 plugin that is true.

Again the easiest option would have been to wait merging #1387 as we can easily merge and test on a PR.
I suggest next time we keep it as a draft.

@jetersen jetersen disabled auto-merge August 9, 2022 20:58
@jetersen jetersen marked this pull request as draft August 9, 2022 20:58
@timja
Copy link
Member

timja commented Aug 9, 2022

Generally plugins that are targeting the next LTS will start to pickup the next bom artifact, we've published it in advance for ages.

No rush for this specific PR though

@jetersen jetersen mentioned this pull request Aug 10, 2022
6 tasks
…/b...

... om/updatecli/update-jenkins.ps1 2.346.x 2.346.3"

Made with ❤️️ by updatecli
@jetersen jetersen changed the title Bump jenkins.version from 2.346.1 to 2.346.2 for bom-2.346.x Bump jenkins.version from 2.346.1 to 2.346.3 for bom-2.346.x Aug 10, 2022
@jetersen
Copy link
Member

@basil I take you still want to wait after 2.361.1 release?
Or are we good with 2.346.3?

@basil
Copy link
Member

basil commented Aug 10, 2022

Since the documentation currently recommends 2.346.1 (and will continue doing so for the next month), I have a slight preference for continuing to deliver that in bom-2.346 throughout the same time period. This is not a strong preference.

@jetersen
Copy link
Member

Lets wait, no rush :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…96aa1744fafc072515ab798fc21f6b37
@basil basil marked this pull request as ready for review September 6, 2022 18:13
@basil
Copy link
Member

basil commented Sep 6, 2022

Shall we proceed with this now? I think the time has come.

@timja timja merged commit 83bfb81 into master Sep 6, 2022
@timja timja deleted the updatecli_a7afe198748e9468e2b93ac22388e9a296aa1744fafc072515ab798fc21f6b37 branch September 6, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants