Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copyartifact to the managed set #1385

Merged
merged 15 commits into from
Aug 12, 2022
Merged

Add copyartifact to the managed set #1385

merged 15 commits into from
Aug 12, 2022

Conversation

basil
Copy link
Member

@basil basil commented Aug 9, 2022

No description provided.

@basil basil added the enhancement New feature or request label Aug 9, 2022
@basil basil mentioned this pull request Aug 9, 2022
Merged
@basil
Copy link
Member Author

basil commented Aug 9, 2022

Unrelated problems aside, note that copyartifact passed in the second run and failed in the first, demonstrating the correctness of jenkinsci/copyartifact-plugin#150

@basil basil mentioned this pull request Aug 10, 2022
Merged
@basil
Copy link
Member Author

basil commented Aug 10, 2022

I'm a bit stumped by these test failures so far:

Architecture Violation [Priority: MEDIUM] - Rule 'no classes that do not have simple name 'JenkinsFacade' should call method Jenkins.getInstance() or should call method Jenkins.getInstanceOrNull() or should call method Jenkins.getActiveInstance() or should call method Jenkins.get()' was violated (2 times):
Method <io.jenkins.plugins.junit.storage.JunitTestResultStorageDescriptor.all()> calls method <jenkins.model.Jenkins.get()> in (JunitTestResultStorageDescriptor.java:12)
Method <io.jenkins.plugins.junit.storage.TestResultImpl.getRun()> calls method <jenkins.model.Jenkins.get()> in (TestResultImpl.java:87)

These failures occur in PCT for checks-api, but only when copyartifact is added to the managed set. Additionally they are complaining about something in junit. None of this makes much sense to me.

@basil basil mentioned this pull request Aug 10, 2022
Merged
@basil
Copy link
Member Author

basil commented Aug 10, 2022

Ah I think I found the bug: checks-api is analyzing classes from outside its package namespace, seemingly incorrectly: jenkinsci/checks-api-plugin#182

@basil basil marked this pull request as ready for review August 12, 2022 00:50
jglick
jglick approved these changes Aug 12, 2022
View reviewed changes
Jenkinsfile
@@ -52,6 +52,9 @@ lines.each {line ->
plugins.each { plugin ->
branches["pct-$plugin-$line"] = {
def jdk = line == 'weekly' ? 17 : 11
if (plugin == 'copyartifact') {
jdk = 11 // https://github.com/jenkinsci/copyartifact-plugin/pull/150
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/copyartifact-plugin#150

pct.sh
# because later releases of the test harness enforce invariants in properties files that this
# plugin does not currently satisfy.
#
# TODO When this plugin is using a recent plugin parent POM, this can be deleted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/copyartifact-plugin#150 again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@basil basil merged commit 564b0d8 into jenkinsci:master Aug 12, 2022
@basil basil deleted the copyartifact branch August 12, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@jetersen jetersen Awaiting requested review from jetersen

@timja timja Awaiting requested review from timja

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basil @jglick