Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli validate output #1290

Merged
merged 7 commits into from Jul 20, 2022
Merged

updatecli validate output #1290

merged 7 commits into from Jul 20, 2022

Conversation

jetersen
Copy link
Member

updatecli does not behave the same, sometimes output is empty.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jetersen jetersen enabled auto-merge (squash) July 19, 2022 23:38
@jetersen jetersen disabled auto-merge July 20, 2022 01:16
@basil
Copy link
Member

basil commented Jul 20, 2022

Is this related to the failure in https://github.com/jenkinsci/bom/runs/7420584581?check_suite_focus=true ?

@jetersen
Copy link
Member Author

jetersen commented Jul 20, 2022

Ya @basil it is all related to updatecli being very rigid about environment variables as is none the shell is completely blind.

it does not have access to PATH env so I cannot use curl nor java I have to write the full path.

updatecli/updatecli#754

scmid: github
jenkins2.346.x:
name: 'Update 2.346.x plugins'
sourceid: jenkins2.346.x
kind: shell
spec:
command: pwsh -NoProfile -File ./updatecli/updatecli.d/update-plugins.ps1
command: pwsh -NoProfile -File ./updatecli/updatecli.d/update-plugins.ps1 {{ requiredEnv .github.jar }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olblak look at this hack to pass path for the jar 😅

@jetersen jetersen merged commit 23f2562 into jenkinsci:master Jul 20, 2022
@jglick jglick added the chore Reduces future maintenance label Jul 21, 2022
@jglick
Copy link
Member

jglick commented Jul 21, 2022

@jetersen jetersen deleted the fix/updatecli branch July 22, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants