simplify updatecli pinned and add 2.346.x however pinned to .1 #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
commented
Jul 19, 2022
jetersen
commented
Jul 19, 2022
| token: "{{ requiredEnv .github.token }}" | ||
| versionfilter: | ||
| kind: regex | ||
| pattern: 'jenkins-2.346.1$' # fix to x.x.1 until the next stable minor release |
There was a problem hiding this comment.
relatively easy to bump the version pattern to .\d+$ and add the next stable minor release and add the new stable release pinned to .1$
jetersen
commented
Jul 19, 2022
Comment on lines
+36
to
+37
| [string] $output = & $java -jar "$pluginManagerJar" --no-download --available-updates --output txt --jenkins-version "$JenkinsVersion" --plugins $plugin | ||
| if ($output -ne $plugin) { |
There was a problem hiding this comment.
nice this will always output the plugin either with the email-ext:2.86 or when updates are available email-ext:2.87 making comparison much easier.
1 task
jetersen
commented
Jul 19, 2022
timja
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally after pushing and pointing values.yaml to this branch.