I want to host a plugin

[rian-gomes]

Repository URL

https://github.com/xmart-xguardian/plugin-jenkins

New Repository Name

xguardian-plugin

Description

A plugin called Xguardian for automatically zip the workspace and upload the source code for the Xguardian platform.

GitHub users to have commit permission

@rian-gomes
@sudo-srv
@nicollasteixeira
@jenkins-xguardian
@isabelasilva2022
@pedrogmagri

Jenkins project users to have release permission

xmart_solutions

Issue tracker

Jira

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.414.3</jenkins.version> to at least 2.426.3 in your pom.xml. Take a look at the baseline recommendations.
• ⛔ Required: The parent pom version '4.73' should be at least '4.78' or higher.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: xmart_solutions (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: sudo-srv nicollasteixeira jenkins-xguardian isabelasilva2022 pedrogmagri rian-gomes

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

• /audit-ok => the audit is complete, the hosting can continue 🎉.
• /audit-skip => the audit is not necessary, the hosting can continue 🎉.
• /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.0)

[jenkins-cert-app]

The Jenkins Security Scan discovered 4 finding(s) 🔍.

Please follow the instructions below for every identified issues:

• Implement the recommended fix to address the issue.
• If you think it's a false positive, suppress the warning directly within the code.
• Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

• If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
• If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

---

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

Xguardian.java#40

Field should be reviewed whether it stores a password and is serialized to disk: password

Xguardian.java#491

Field should be reviewed whether it stores a password and is serialized to disk: password

Xguardian.java#507

Field should be reviewed whether it stores a password and is serialized to disk: token

XguardianGlobalConfiguration.java#16

Field should be reviewed whether it stores a password and is serialized to disk: password

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.414.3</jenkins.version> to at least 2.426.3 in your pom.xml. Take a look at the baseline recommendations.
• ⛔ Required: The parent pom version '4.73' should be at least '4.78' or higher.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: xmart_solutions (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: sudo-srv nicollasteixeira jenkins-xguardian isabelasilva2022 pedrogmagri rian-gomes

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: rian-gomes, nicollasteixeira (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: rian-gomes, nicollasteixeira (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[mawinter69]

• The plugin doesn't support pipeline jobs.
• It can only work when the build happened on the controller as it directly tries to zip files in code that runs on the controller. So when I use the step for a job that runs on an agent it will fail
• Inline javascript and style tags
• inline javascript usage with onclick (lines 170 and 176)
• the javascript code is very hard to read without any indentation
• the bootstrap stuff seems to be unused
• direct usage of external resource (https://cdn.jsdelivr.net/npm/axios/dist/axios.min.js) That might be a problem for the one or other admin that doesn't want to allow access to cdn.jsdelivr.net
• there is no config.jelly for the global configuration. The global configuration is not used at all
• button with purple color (really?) Please stick to Jenkins styling
• use f:password to get a password input field (https://github.com/xmart-xguardian/plugin-jenkins/blob/1919dcd8147f08b03b9a98f5b1a65c7a69b5af49/src/main/resources/io/jenkins/plugins/Xguardian/config.jelly#L167)
• typically one does things like connection testing in the java code and return a formvalidation object (you already have a method there)
• direct usage of okhttp, jackson, httpclient
• dependencies like structs or stapler are not required
• the jenkins version and the version of the bom are not in sync