Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to host a plugin repository #3819

Open
RohitKBhatnagar opened this issue Mar 16, 2024 · 16 comments
Open

Request to host a plugin repository #3819

RohitKBhatnagar opened this issue Mar 16, 2024 · 16 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@RohitKBhatnagar
Copy link

RohitKBhatnagar commented Mar 16, 2024

Repository URL

https://github.com/RohitKBhatnagar/folder-tear-down

New Repository Name

folder-tear-down-plugin

Description

Folder-Tear-Down plugin will allow tearing of entire folder which may host workflow type pipelines including multi-branch pipelines as well as credentials if any defined within that folder. Primary purpose would be to allow proper cleanup of entire folder as specified. Plugin may be extended to allow various job types for tear down.

GitHub users to have commit permission

@RohitKBhatnagar

Jenkins project users to have release permission

RohitKBhatnagar

Issue tracker

Jira

@RohitKBhatnagar RohitKBhatnagar added the hosting-request Request to host a component in jenkinsci label Mar 16, 2024
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.0)

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.277.1</jenkins.version> to at least 2.426.3 in your pom.xml. Take a look at the baseline recommendations.
  • ⛔ Required: The parent pom version '4.27' should be at least '4.78' or higher.
  • ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Mar 16, 2024
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Mar 16, 2024
@RohitKBhatnagar
Copy link
Author

/hosting re-check
Upgraded plugin parent pom version as well as Jenkins version as per the guidance. Additionally updated the repository name to include -plugin or 'folder-tear-down-plugin' repository name.
Thanks

@RohitKBhatnagar
Copy link
Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@NotMyFault
Copy link
Member

Hey,

could you fill out the README.md with details how this plugin works, what it aims for to solve etc.? That would facilitate reviewing a lot. An example, how a well-written plugin description can look like, can be found here: https://plugins.jenkins.io/jetbrains-space/

@RohitKBhatnagar
Copy link
Author

/hosting re-check
Sorry about that somehow I missed providing the necessary details. I have updated the ReadMe.md and also insured that the pom specifies the repository name with -plugin as suffix.
New Repository Name - folder-tear-down-plugin

@RohitKBhatnagar
Copy link
Author

RohitKBhatnagar commented Mar 18, 2024 via email

@RohitKBhatnagar
Copy link
Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added bot-check-complete Automated hosting checks passed and removed needs-fix labels Mar 18, 2024
@NotMyFault
Copy link
Member

I still do not understand, what this plugin is supposed to solve. Nor am I confident that you have tested your functionality boldly because the existing folder structure basically blows up your Jenkins instance, if you tried to create a pipeline job.

@RohitKBhatnagar
Copy link
Author

/hosting re-check
Hello,
Sorry for all the confusions at my end. I thought just simply updating the parent pom with suffix of plugin would be sufficient. I didn't realize my GitHub repository is not created with -plugin suffix. My apologies for any inconvenience. I have updated the ReadMe.md file with the purpose of this plugin including how to run the same.
GitHub URL - https://github.com/RohitKBhatnagar/folder-tear-down-plugin
Kindly review the same
Thanks

@RohitKBhatnagar
Copy link
Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

3 participants