Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert groovy classes to Java #3028

Open
NotMyFault opened this issue Dec 16, 2022 · 6 comments
Open

Convert groovy classes to Java #3028

NotMyFault opened this issue Dec 16, 2022 · 6 comments

Comments

@NotMyFault
Copy link
Member

There are a few Groovy classes which should be moved to Java. Not only does that align with the tooling structure, it also allows us to drop the (very dated) groovy dependencies, to prepare for a more robust future in Java.

@shivang-sharma
Copy link

Hi @NotMyFault,
I want to work on this issue.
It will help a lot if you could point me to some documentation explaining how I can test and verify this repository once I make some changes.
Thanks

@NotMyFault
Copy link
Member Author

The Jenkinsfile contains the steps how this application is run:

def javaArgs = ' -DdefinitionsDir=$PWD/permissions' +

@daniel-beck
Copy link
Contributor

System properties and environment variables are documented at https://github.com/jenkins-infra/repository-permissions-updater#usage

@shivang-sharma
Copy link

Thankyou @NotMyFault and @daniel-beck for the info.

@shivang-sharma
Copy link

Hi @NotMyFault and @daniel-beck,
Please review my first PR #3102.
I need feedback for the below code.
I have used @SuppressFBWarnings("URLCONNECTION_SSRF_FD") on line number 400 because I was getting this issue for the URL that is being used to open the connection I tried implementing a few checks but still I was getting this issue and @SuppressFBWarnings("DM_DEFAULT_ENCODING") at line number 333 because I was getting this issue while accessing the inputStream and outputStream of the connection.
I have converted 1 file only and once this is approved I will work on the others and keep in mind all the suggestions and feedback from now on.

@shivang-sharma
Copy link

Hi @NotMyFault and @daniel-beck,
Please review PR #3102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants