Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin versions are not sorted properly #1336

Open
mawinter69 opened this issue Apr 18, 2023 · 0 comments
Open

Plugin versions are not sorted properly #1336

mawinter69 opened this issue Apr 18, 2023 · 0 comments
Labels

Comments

@mawinter69
Copy link

mawinter69 commented Apr 18, 2023

Problem with this page

https://plugins.jenkins.io/role-strategy/releases/

Expected behavior

The versions are reported in the same way as in github and as Jenkins itself does it internally
e.g. here
https://updates.jenkins.io/download/plugins/role-strategy/
and here
https://plugin-site-issues.jenkins.io/api/plugin/role-strategy/releases/

Actual behavior

The version 587.588.v850a_20a_30162 is shown below version 587.v2872c41fa_e51 even though it is newer and Jenkins internally considered the higher version

Possible solution

The root cause is that Jenkins VersionNumber sorting is quite complex compared to update site here

@mawinter69 mawinter69 added the bug label Apr 18, 2023
mawinter69 added a commit to mawinter69/update-center2 that referenced this issue Apr 18, 2023
the file plugin-versions.json is the base for sorting the releases of a
plugin on the plugins page at https://plugins.jenkins.io
The sorting with string causes wrong ordering in some cases as described
in jenkins-infra/plugin-site#1336

By sorting with the Comparator of VersionNumber we get the same sorting
as in other places.
daniel-beck pushed a commit to jenkins-infra/update-center2 that referenced this issue Mar 8, 2024
the file plugin-versions.json is the base for sorting the releases of a
plugin on the plugins page at https://plugins.jenkins.io
The sorting with string causes wrong ordering in some cases as described
in jenkins-infra/plugin-site#1336

By sorting with the Comparator of VersionNumber we get the same sorting
as in other places.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant