From 2506f1071e91cb82414b5fe0578c2104f64a54af Mon Sep 17 00:00:00 2001 From: Joseph Petersen Date: Mon, 13 Jun 2022 23:19:31 +0200 Subject: [PATCH 1/3] move variables to env block --- action.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/action.yaml b/action.yaml index a4d7b2b..51e3322 100644 --- a/action.yaml +++ b/action.yaml @@ -3,10 +3,13 @@ description: Deploys a Maven project to the Jenkins Artifactory repository in co inputs: GITHUB_TOKEN: required: true + description: Token to run with, defaults to the repository GITHUB_TOKEN MAVEN_USERNAME: required: true + description: Maven Username used to release to Jenkins Artifactory repository MAVEN_TOKEN: required: true + description: Maven Token used to release to Jenkins Artifactory repository INTERESTING_CATEGORIES: required: true description: | @@ -16,6 +19,10 @@ inputs: default: '[💥🚨🎉🐛⚠🚀🌐👷]|:(boom|tada|construction_worker):' runs: using: composite - steps: - - run: GITHUB_TOKEN=${{ inputs.GITHUB_TOKEN }} MAVEN_USERNAME=${{ inputs.MAVEN_USERNAME }} MAVEN_TOKEN=${{ inputs.MAVEN_TOKEN }} INTERESTING_CATEGORIES='${{ inputs.INTERESTING_CATEGORIES }}' $GITHUB_ACTION_PATH/run.sh + steps: + - run: $GITHUB_ACTION_PATH/run.sh shell: bash + env: + GITHUB_TOKEN: ${{ inputs.GITHUB_TOKEN }} + MAVEN_USERNAME: ${{ inputs.MAVEN_USERNAME }} + INTERESTING_CATEGORIES: ${{ inputs.INTERESTING_CATEGORIES }} From b67cdeea0ce8bff7f094ef28794defdac4e46091 Mon Sep 17 00:00:00 2001 From: Joseph Petersen Date: Mon, 13 Jun 2022 23:40:42 +0200 Subject: [PATCH 2/3] Update action.yaml --- action.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/action.yaml b/action.yaml index 51e3322..eb3d5fe 100644 --- a/action.yaml +++ b/action.yaml @@ -25,4 +25,5 @@ runs: env: GITHUB_TOKEN: ${{ inputs.GITHUB_TOKEN }} MAVEN_USERNAME: ${{ inputs.MAVEN_USERNAME }} + MAVEN_TOKEN: ${{ inputs.MAVEN_TOKEN }} INTERESTING_CATEGORIES: ${{ inputs.INTERESTING_CATEGORIES }} From 8c70996218f23303b9e4df34dda68aaea63c7eff Mon Sep 17 00:00:00 2001 From: Joseph Petersen Date: Tue, 14 Jun 2022 01:00:35 +0200 Subject: [PATCH 3/3] Apply suggestions from code review --- action.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/action.yaml b/action.yaml index eb3d5fe..7953162 100644 --- a/action.yaml +++ b/action.yaml @@ -6,10 +6,10 @@ inputs: description: Token to run with, defaults to the repository GITHUB_TOKEN MAVEN_USERNAME: required: true - description: Maven Username used to release to Jenkins Artifactory repository + description: Maven username used for deploying the plugin jar to Jenkins Artifactory Repository MAVEN_TOKEN: required: true - description: Maven Token used to release to Jenkins Artifactory repository + description: Maven token used for deploying the plugin jar to Jenkins Artifactory Repository INTERESTING_CATEGORIES: required: true description: |