Quietly skipped incrementals deployment after retry

[jglick]

Service(s)

ci.jenkins.io

Summary

@olamy noticed that jenkinsci/ec2-plugin#951 did not publish to Incrementals. Plugin metadata looks OK. From the steps run in https://ci.jenkins.io/job/Plugins/job/ec2-plugin/job/PR-951/1/flowGraphTable/ I can infer that incrementals got set correctly but archivedArtifacts did not, which may be a consequence of https://ci.jenkins.io/job/Plugins/job/ec2-plugin/job/PR-951/1/execution/node/20/log/ failing and then retrying. I suspect https://github.com/jenkins-infra/pipeline-library/blob/a55180931b34012ef0736828b22416b7043693cb/vars/buildPlugin.groovy#L68-L72 is in the wrong place: it should be outside the retry loop (jenkins-infra/pipeline-library#405), and in fact it should probably be outside the branch closure as well.

Reproduction steps

No response