Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WARNING log when trying to send an email to a user without any valid email registered #286

Open
lemeurherve opened this issue Jul 31, 2023 · 0 comments · May be fixed by #289
Open
Labels

Comments

@lemeurherve
Copy link
Member

lemeurherve commented Jul 31, 2023

Problem with this page

N/A

Expected behavior

When the app try to send an email to a user, log a WARNING about the email if missing or not valid (ex: the accounts concerned by the LDAP incident from previous years where some emails have been replaced)

Ref: jenkins-infra/helpdesk#3695 (comment)

Actual behavior

No log is emitted.

Possible solution

Add a new item in blockReasons if the user email is empty or not valid: https://github.com/jenkins-infra/account-app/blob/main/src/main/java/org/jenkinsci/account/Application.java#L158-L219

@lemeurherve lemeurherve changed the title Add a WARNING log when trying to send an email to a user without any email registered Add a WARNING log when trying to send an email to a user without any valid email registered Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant