-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise transcoding kill timeout. #11643
base: master
Are you sure you want to change the base?
Conversation
The Chromecast client only pings every 10 seconds, so having a 10 second timeout will result in spurious killing any time there is slight deviation in the polling. Set to a much safer value so that transcoding will only get killed if there is a serious hang somewhere.
This timeout appears to have been introduced by @crobibero in #3460. |
I believe this is not the problem if your playback does not even start |
It isn't the main problem, but it is a problem. The fact is that 10s pings with a 10s timeout isn't going to work reliably. |
Except we are not: On chromecast we are pinging at 5s. |
That isn't what I am seeing in the nginx access logs: https://github.com/jellyfin/jellyfin/files/15312949/jellyfin.txt |
Trying the Unstable channel the pings seem to be usually a bit over 5s, but just copying the last few I did notice a missed one at 11s. Even then a bit more buffer would be good.
|
Ok, in that trace I double checked though and the logs from the Stable Chromecast don't have a progress update in the gap, so they are still only going every 10s. |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Does Chromecast even use Progressive streams? I don't think so, but not sure. |
From the Chromecast Client source code it does, but that pings the server at 5 second interval which should be good enough. |
Changes
The Chromecast client only pings every 10 seconds, so having a 10 second timeout will result in spurious killing any time there is slight deviation in the polling. Set to a much safer value so that transcoding will only get killed if there is a serious hang somewhere.
Issues
Fixes: #11640