Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the default layout from default to base was a questionable idea #771

Open
michaelnordmeyer opened this issue Jan 6, 2024 · 0 comments

Comments

@michaelnordmeyer
Copy link

In #690 the default layout was renamed from default.html to base.html.

While the given rationale is not wrong, it ignores the Jekyll documentation regarding layouts:

The convention is to have a base template called default.html and have other layouts inherit from this as needed.

There is a plugin called jekyll-default-layout, which is installed through the GitHub Pages gem by default.

A solution for having both was mentioned in #690 (comment), but I don't think there's much to gain by having a layout called base instead of default. It most likely leads to more confusion.

I for one consider the default naming scheme to be more helpful, because it conveys the notion that this is the default layout, which will be used as default if nothing is declared, and is not extended with any particular functionality, which might only apply to a subset of pages.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant