Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS is deprecating the ability to use a / (slash) for division. #709

Open
CodeAsm opened this issue Feb 6, 2023 · 17 comments
Open

SASS is deprecating the ability to use a / (slash) for division. #709

CodeAsm opened this issue Feb 6, 2023 · 17 comments

Comments

@CodeAsm
Copy link

CodeAsm commented Feb 6, 2023

During site deployment, i get deprecation warnings. Similiar to the suggested fix here:
#705 seems to indicate the same issue im having

remote: 
remote: Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)
remote: 
remote: More info and automated migrator: https://sass-lang.com/d/slash-div
remote: 
remote:     ╷
remote: 134 │   padding-left: $spacing-unit / 2;
remote:     │                 ^^^^^^^^^^^^^^^^^
remote:     ╵
remote:     ../../../../minima-2.5.1/_sass/minima/_base.scss 134:17  @import
remote:     minima.scss 48:3                                         @import
remote:     /home/[snip]/git/site/assets/main.scss 1:9       root stylesheet
remote: DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

running the suggested command wont work remote, as these codes are inside the downloaded template. I would love to get rid of minima, but seeing its a default template and pretty minimal, this needs fixing for more people. Whatever a default would be, more people stumble upon this problem right?

@cdcooksey
Copy link

I've been getting the same:

190 │     padding-left: $spacing-unit / 2;
    │                   ^^^^^^^^^^^^^^^^^
    ╵
    ../../../../minima-2.5.1/_sass/minima/_base.scss 190:19  @content
    minima.scss 38:5                                         media-query()
    ../../../../minima-2.5.1/_sass/minima/_base.scss 186:3   @import
    minima.scss 48:3                                         @import
    /home/charlie/g/cooksey.io/assets/main.scss 1:9          root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacing-unit, 3) or calc($spacing-unit / 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
244 │     padding: ($spacing-unit / 3) ($spacing-unit / 2);
    │               ^^^^^^^^^^^^^^^^^
    ╵
    ../../../../minima-2.5.1/_sass/minima/_base.scss 244:15  @import
    minima.scss 48:3                                         @import
    /home/charlie/g/cooksey.io/assets/main.scss 1:9          root stylesheet
Warning: 6 repetitive deprecation warnings omitted.

@ashmaroli
Copy link
Member

@cdcooksey This has been addressed on the master. There are no plans to ship a release in the near future.

You have multiple options at your disposal:

  • The root cause of these warnings are from jekyll-sass-converter-3.0.0 which uses a new implementation of Sass. You can edit your Gemfile to use only jekyll-sass-converter-2.x. Or you can continue using the v3 of sass-converter but disable these warnings via your config file:
    # _config.yml
    
    sass:
      quiet_deps: true
  • Another route is to use the unreleased version of the theme directly from the GitHub repo using the jekyll-remote-theme. However, do note that the unreleased changes include numerous breaking changes and will continue to incorporate more breaking changes until release.

@rockstorm101
Copy link

Or you can continue using the v3 of sass-converter but disable these warnings via your config file

Thank you providing a workaround, it was annoying to see the warning on every build. Looking forward to the next release!

@k4u5hik
Copy link

k4u5hik commented Feb 24, 2023

Appreciate your clear response @ashmaroli. I have been searching for an answer on this issue.

@johnnypeck
Copy link

This has been bothering me as well until finding this. Not being familiar with Jekyll or Sass much then presented with immediate errors first run with bundle exec jekyll serve is unnerving. Add maintenance cost immediately. Coders love it when things are failing and flimsy and need fixing from the get go. Right? Seems to me there should be a release. This is a mental blocker of an issue that doesn't need to confront every new user, instills lack of trust in the product immediately and looks bad.

Just my 2-cents. I do love Jekyll. Seriously. A lot.

@joshbuker
Copy link

joshbuker commented Mar 5, 2023

This seems perfect for a patch-level release, considering it causes deprecation warnings unless suppressed.

Ah, there are breaking changes currently merged into main. Considering there is an easy workaround, it makes more sense why creating a patch release for this is a low priority. It would have been a good idea to keep those breaking changes out of main until they were ready to ship, but that's a lesson for the future.

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added the stale label May 5, 2023
@joshbuker
Copy link

@jekyllbot https://drewdevault.com/2021/10/26/stalebot.html

@jekyllbot jekyllbot removed the stale label May 6, 2023
@aallan
Copy link

aallan commented May 21, 2023

We have temporarily hidden the warnings in our build (raspberrypi/documentation#2866) but would definitely appreciate an upstream fix. Yes, it's not crucial, but it is a horrible user experience.

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@rockstorm101
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least two months.

This is a dumb reply to keep @jekyllbot happy. The issue still persists, and is relevant.

@jekyllbot jekyllbot removed the stale label Jul 21, 2023
@GinoMan
Copy link

GinoMan commented Aug 13, 2023

It seems to be in only one place, why not checkout the last release, make the change, and then do a patch release from there? Then it can be fixed on main later? Git's flexible, this shouldn't be that big of a deal to fix.

fatso83 added a commit to fatso83/holmevann that referenced this issue Sep 8, 2023
@agregen
Copy link

agregen commented Sep 9, 2023

Wasn't this addressed by #700?

@tthvo
Copy link

tthvo commented Sep 20, 2023

Any plan still for a new release with the fixes?

@CodeAsm
Copy link
Author

CodeAsm commented Sep 30, 2023

Wasn't this addressed by #700?

Yeah looks like it. Id prever a new release. whats the issue with making new releases? you dont experiment in main, that's where branches are for.

@joshbuker
Copy link

The last release was in 2019, 4 years ago...

Is Minima in need of a maintainer?

I would normally volunteer, but I'm already hilariously behind on maintaining other projects.

@melroy89
Copy link

Could somebody just make a release and gem? plz :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

14 participants