From b6d5d391f1789f41ff536e5dc5fb7d01ab2e925a Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 10 Jun 2020 19:51:15 +0530 Subject: [PATCH 1/3] Release post for v4.1.1 --- .../2020-06-10-jekyll-4-1-1-released.markdown | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown diff --git a/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown b/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown new file mode 100644 index 00000000000..57683866069 --- /dev/null +++ b/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown @@ -0,0 +1,22 @@ +--- +title: 'Jekyll 4.1.1 Released' +date: 2020-06-10 18:45:35 +0530 +author: ashmaroli +version: 4.1.1 +category: release +--- + +Jekyll 4.1.0 brought two notable changes: *Page-excerpts* and *Liquid Drop for Page objects*. +However these seemingly benign changes had unexpected adverse side-effects which did not figure in our tests. + +The Core team decided that the best way forward is to revert introduction of the Liquid drop for Pages but push back +generating excerpts for pages behind a flag until `v5.0`. + +Page-excerpts are henceforth an opt-in experimental feature which can be enabled by setting `page_excerpts: true` in +your configuration file. Due to its experimental nature, we have narrowed the scope for page-excerpts to limit their +negative effect on builds. Excerpts will not be generated for pages that *do not* output into an HTML file even if +`page_excerpts: true` has been set in the configuration file. + +Another known issue with page-excerpts is that an infinite loop is created in certain use-cases. + +Therefore, we advise caution when opting to use the page-excerpt feature. From ca0a52b4c13bd97665a753264679795d146c97e4 Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 17 Jun 2020 19:39:24 +0530 Subject: [PATCH 2/3] Document known scenarios causing infinite loops --- .../2020-06-10-jekyll-4-1-1-released.markdown | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown b/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown index 57683866069..897450afec3 100644 --- a/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown +++ b/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown @@ -17,6 +17,22 @@ your configuration file. Due to its experimental nature, we have narrowed the sc negative effect on builds. Excerpts will not be generated for pages that *do not* output into an HTML file even if `page_excerpts: true` has been set in the configuration file. -Another known issue with page-excerpts is that an infinite loop is created in certain use-cases. +Another known issue with page-excerpts is that an infinite loop is created in certain use-cases such as any construct +that involves iterating through `site.pages` directly within a `Jekyll::Page` instance. A couple of examples would be +having a variant of either of the following code blocks inside a page source, say `index.markdown` or `about.markdown`: + +{% raw %} + +```liquid +{% for entry in site.pages %} + {{ entry.name }} +{% endfor %} +``` + +```liquid +{{ site.pages | sort: 'title' }} +``` + +{% endraw %} Therefore, we advise caution when opting to use the page-excerpt feature. From 6369aad5af9fdae3f802675de063b7e00fd78af0 Mon Sep 17 00:00:00 2001 From: Ashwin Maroli Date: Wed, 24 Jun 2020 17:07:50 +0530 Subject: [PATCH 3/3] Update release post date --- ...eased.markdown => 2020-06-24-jekyll-4-1-1-released.markdown} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename docs/_posts/{2020-06-10-jekyll-4-1-1-released.markdown => 2020-06-24-jekyll-4-1-1-released.markdown} (97%) diff --git a/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown b/docs/_posts/2020-06-24-jekyll-4-1-1-released.markdown similarity index 97% rename from docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown rename to docs/_posts/2020-06-24-jekyll-4-1-1-released.markdown index 897450afec3..599578ece02 100644 --- a/docs/_posts/2020-06-10-jekyll-4-1-1-released.markdown +++ b/docs/_posts/2020-06-24-jekyll-4-1-1-released.markdown @@ -1,6 +1,6 @@ --- title: 'Jekyll 4.1.1 Released' -date: 2020-06-10 18:45:35 +0530 +date: 2020-06-24 16:45:35 +0530 author: ashmaroli version: 4.1.1 category: release