New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: livereload-ignore option doesn't work #9502
Comments
This can be worked around by putting the path to ignore in the |
I encountered this bug on Windows 10 with Jekyll 4.3.3. I used this configuration setting in livereload_ignore: [ '/assets/images/qrcodes/*' ] When my generator writes files into The problem is the call on line 161 of File.fnmatch(filter, Jekyll.sanitized_path(p.relative_path)) The comment and method signature are: # Public: Ensures the questionable path is prefixed with the base directory
# and prepends the questionable path with the base directory if false.
#
# base_directory - the directory with which to prefix the questionable path
# questionable_path - the path we're unsure about, and want prefixed
#
# Returns the sanitized path.
def sanitized_path(base_directory, questionable_path) One easy way to fix this bug would be simply to avoid the call to File.fnmatch(filter, p.relative_path) I tested this and it worked. Incidentally, the Jekyll docs should mention that the contents of the |
Makes `livereload_ignore` finally work properly.
Operating System
macOS 14.1.2
Ruby Version
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin23]
Jekyll Version
jekyll 4.3.2
GitHub Pages Version
No response
Expected Behavior
After specifying
^\.wrangler\/
in thelivereload-ignore
config parameter or the--livereload_ignore
command line argument, files changing in the.wrangler
directory should not trigger a live reload when runningbundler exec jekyll serve --livereload
.Current Behavior
Files changing in the
.wrangler
directory trigger a live reload, and the verbose output shows that.wrangler
is not making it tojekyll-watch
for ignoring:Relevant log output
No response
Code Sample
No response
The text was updated successfully, but these errors were encountered: