Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Incrementally rebuild when a data file is changed" #9170

Merged
merged 1 commit into from Oct 26, 2022

Conversation

ashmaroli
Copy link
Member

Summary

While investigating the reason behind #9165, I realized that patching the reported issue would only act as a band-aid and change in behavior elsewhere will exist until someone reports it. The better solution in order to honor Jekyll's SemVer policy is to revert the causal commit.

Reverts #8771

Context

Resolves #9165

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 5367a02 into master Oct 26, 2022
@jekyllbot jekyllbot deleted the revert-8771-site_data-module branch October 26, 2022 16:38
jekyllbot added a commit that referenced this pull request Oct 26, 2022
github-actions bot pushed a commit that referenced this pull request Oct 26, 2022
Ashwin Maroli: Revert "Incrementally rebuild when a data file is changed (#8771)" (#9170)

Merge pull request 9170
ashmaroli added a commit that referenced this pull request Oct 27, 2022
ashmaroli pushed a commit that referenced this pull request Oct 27, 2022
lylo pushed a commit to lylo/jekyll that referenced this pull request Oct 27, 2022
lylo pushed a commit to lylo/jekyll that referenced this pull request Oct 27, 2022
lylo pushed a commit to lylo/jekyll that referenced this pull request Oct 27, 2022
* master: (27 commits)
  Remove noise in `features/highlighting.feature`
  Release 💎 v4.3.1
  Update history to reflect merge of jekyll#9171 [ci skip]
  Release post for v4.3.1 (jekyll#9171)
  Update history to reflect merge of jekyll#9170 [ci skip]
  Revert "Incrementally rebuild when a data file is changed (jekyll#8771)" (jekyll#9170)
  Update history to reflect merge of jekyll#9167 [ci skip]
  Respect user-defined name attribute in documents (jekyll#9167)
  Revert back to developing 4.3.x
  Mark initiation of v5.0 development
  Disable critical GH Actions on `master`
  Fix spelling errors in History document
  Release 💎 v4.3.0
  Update history to reflect merge of jekyll#9157 [ci skip]
  Release post for v4.3.0 (jekyll#9157)
  Clean up HEAD section in History document
  Document xz dependency on macOS (jekyll#9098)
  Fix URL to Liquid documentation (jekyll#9158)
  Bump RuboCop to `v1.37.x`
  Update history to reflect merge of jekyll#9132 [ci skip]
  ...
@jekyll jekyll locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 4.3 not reading data from site.<collection> correctly.
2 participants