Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency constraint to allow for liquid v5.4.0 #9094

Closed
jekyllbot opened this issue Jul 29, 2022 · 10 comments
Closed

Update dependency constraint to allow for liquid v5.4.0 #9094

jekyllbot opened this issue Jul 29, 2022 · 10 comments

Comments

@jekyllbot
Copy link
Contributor

Hey there! 👋

I noticed that the constraint you have for liquid doesn't allow for the latest version to be used.

The constraint I found was ~> 4.0, and the latest version available is 5.4.0.

Can you look into updating that constraint so our users can use the latest and greatest version? Thanks! 💞

@HoneyryderChuck
Copy link

As per this changelog entry, jekyll will need to update to liquid 5 to work with ruby 3.2 .

@yboulkaid
Copy link
Contributor

This is blocked by Shopify/liquid#1566

@ashmaroli
Copy link
Member

Yes, that issue is a wrench in our mechanism but apart from that, I had unknowingly introduced a coupling to Liquid internals:

def compare_property_vs_target(property, target)
case target
when NilClass
return true if property.nil?
when Liquid::Expression::MethodLiteral # `empty` or `blank`
target = target.to_s
return true if property == target || Array(property).join == target
else
target = target.to_s
if property.is_a? String
return true if property == target
else
Array(property).each do |prop|
return true if prop.to_s == target
end
end
end
false
end

philnash added a commit to philnash/jekyll-mastodon_webfinger that referenced this issue Nov 20, 2022
…e liquid

Liquid v4 fails on Ruby 3.2 due to removed methods. Liquid v5 fixes this, but Jekyll still relies on Liquid v4. See jekyll/jekyll#9094.

Can add back Ruby 3.2 or ruby-head when Jekyll supports Liquid v5.
@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Nov 29, 2022
@jekyllbot
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the latest 3.x-stable or master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@parkr
Copy link
Member

parkr commented Dec 25, 2022

Cc github/pages-gem#859

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Dec 25, 2022
@jekyllbot
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the latest 3.x-stable or master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Feb 25, 2023
@parkr
Copy link
Member

parkr commented Feb 25, 2023

This is still blocked by Shopify/liquid#1566.

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Feb 25, 2023
@ashmaroli
Copy link
Member

@parkr The issue you have linked to isn't the only blocker.
There's also the issue described in Shopify/liquid#1663 and Shopify/liquid#1662

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Apr 26, 2023
@jekyllbot
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the latest 3.x-stable or master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
@nickmccurdy
Copy link

Duplicate of #8535

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants