Remove misleading totals row from --profile table
#9039
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattr-
approved these changes
Apr 28, 2022
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Apr 28, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
Ashwin Maroli: Remove misleading total row from `--profile` table (#9039) Merge pull request 9039
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The total time printed as part of the build profile table is often significantly different from the total time reported in the Build Summary table. Therefore, stop outputting the info that is more misleading than beneficial.
(Deferring a "fix" per se, for future)
Context
Closes #8796