Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and fix CI for 3.9-stable on Ruby 3.x #8942

Merged
merged 20 commits into from
Jan 20, 2022
Merged

Update and fix CI for 3.9-stable on Ruby 3.x #8942

merged 20 commits into from
Jan 20, 2022

Conversation

parkr
Copy link
Member

@parkr parkr commented Jan 20, 2022 •
edited

This is a 🔨 code refactoring.

Summary

Update CI to latest version from the master branch and fix CI for Ruby 3.1.

  • Copy-paste ci.yaml workflow from master
  • Copy-paste release.yaml workflow from master
  • Fix Ruby 3.0 and 3.1 compatibility issues

Context

Commits are cherry-picked from #8939.

@parkr parkr changed the title 3.x: Update and fix CI for Ruby 3.x [3.9-stable] Update and fix CI for Ruby 3.x Jan 20, 2022
@parkr parkr requested a review from ashmaroli January 20, 2022 04:26
@ashmaroli ashmaroli mentioned this pull request Jan 20, 2022
Merged
@ashmaroli ashmaroli changed the title [3.9-stable] Update and fix CI for Ruby 3.x Update and fix CI for 3.9-stable on Ruby 3.x Jan 20, 2022
@ashmaroli ashmaroli merged commit ee1d210 into 3.9-stable Jan 20, 2022
@ashmaroli ashmaroli deleted the update-and-fix-ci branch January 20, 2022 12:33
@ashmaroli ashmaroli added ⏪ backport Changes will be merged into an older stable branch fix labels Jan 20, 2022
ashmaroli added a commit that referenced this pull request Jan 20, 2022
@ashmaroli
Update history to reflect merge of #8942 [ci skip]
76ef58e
@ashmaroli
Copy link
Member

ashmaroli commented Jan 20, 2022 •
edited

Thank you @parkr
I made some additional changes to this branch:

  • Remove check for older Ruby versions in Gemfile
  • Skip Cucumber tests on JRuby (because this branch tests use of Redcarpet and RDiscount which master doesn't)
  • Modify your change to lib/jekyll/utils/platform.rb to be compatible with the module's public methods. (Additionally, rescuing Errno::EACCES is an enhancement and needs to be done in a separate PR if you wish to support that).

Additionally, we stopped testing with older versions of Rouge and kramdown when we migrated away from TravisCI in 433d449 (my bad!). Let me know if they should be re-introduced for this branch.

Arkanaaiden
Arkanaaiden approved these changes Oct 1, 2022
View reviewed changes
Copy link

@Arkanaaiden Arkanaaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@jekyll jekyll locked and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

@Arkanaaiden Arkanaaiden Arkanaaiden approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age old-stable ⏪ backport Changes will be merged into an older stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@parkr @ashmaroli @Arkanaaiden @jekyllbot