Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency constraint to allow for rubocop v1.14.0 #8673

Closed
jekyllbot opened this issue May 14, 2021 · 3 comments
Closed

Update dependency constraint to allow for rubocop v1.14.0 #8673

jekyllbot opened this issue May 14, 2021 · 3 comments

Comments

@jekyllbot
Copy link
Contributor

Hey there! 馃憢

I noticed that the constraint you have for rubocop doesn't allow for the latest version to be used.

The constraint I found was ~> 1.12.0, and the latest version available is 1.14.0.

Can you look into updating that constraint so our users can use the latest and greatest version? Thanks! 馃挒

@kmk3
Copy link
Contributor

kmk3 commented May 16, 2021

@jekyllbot commented 2 days ago:

Hey there! wave

I noticed that the constraint you have for rubocop doesn't allow for the
latest version to be used.

The constraint I found was ~> 1.12.0, and the latest version available is
1.14.0.

Can you look into updating that constraint so our users can use the latest
and greatest version? Thanks! revolving_hearts

Note that this depends on dropping support for Ruby 2.4.

See #8649 and #8651.

Other links for cross-reference: rubocop/rubocop#9648 and #8116.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Jul 16, 2021
@jekyllbot
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the latest 3.x-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@ashmaroli
Copy link
Member

Resolved via 3f46f02

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Aug 4, 2021
@jekyll jekyll locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants