Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showcase #8504

Merged
merged 1 commit into from
Dec 6, 2020
Merged

fix: showcase #8504

merged 1 commit into from
Dec 6, 2020

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Dec 6, 2020

This is a 馃敠 documentation change.

Summary

Dynamic screenshots hosted on Cloudfront weren't loading, replaced with static screenshots served by Cloudinary to ensure optimal performance.

馃憖 Preview on Netlify

Lighthouse Score on Desktop

showcase-lighthouse

Context

Fixes #8491

@DirtyF DirtyF added the site label Dec 6, 2020
@DirtyF
Copy link
Member Author

DirtyF commented Dec 6, 2020

@jekyll: merge +site

@jekyllbot jekyllbot merged commit 46cb37f into master Dec 6, 2020
@jekyllbot jekyllbot deleted the docs/showcase branch December 6, 2020 22:55
jekyllbot added a commit that referenced this pull request Dec 6, 2020
github-actions bot pushed a commit that referenced this pull request Dec 6, 2020
Frank Taillandier: fix: showcase (#8504)

Merge pull request 8504
github-actions bot pushed a commit to tigefa4u/jekyll that referenced this pull request Dec 6, 2020
jekyllbot: Update history to reflect merge of jekyll#8504 [ci skip]
github-actions bot pushed a commit to chauncey-garrett/jekyll that referenced this pull request Dec 7, 2020
jekyllbot: Update history to reflect merge of jekyll#8504 [ci skip]
github-actions bot pushed a commit to patilswapnilv/jekyll that referenced this pull request Dec 7, 2020
jekyllbot: Update history to reflect merge of jekyll#8504 [ci skip]
@jekyll jekyll locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Broken Showcase screenshots
2 participants