Stash attribute hash for Liquid computed for pages #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Dec 10, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2020
Ashwin Maroli: Stash attribute hash for Liquid computed for pages (#8497) Merge pull request 8497
github-actions bot
pushed a commit
to tigefa4u/jekyll
that referenced
this pull request
Dec 10, 2020
jekyllbot: Update history to reflect merge of jekyll#8497 [ci skip]
This was referenced Mar 12, 2021
ashmaroli
added a commit
to ashmaroli/jekyll
that referenced
this pull request
Aug 25, 2021
…)" This reverts commit 01825f5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since
Jekyll::Page#to_liquidisn't memoized, the attribute hash for Liquid gets computed on every call.Therefore compute the attribute hash on first call and stash it for consequent reuse.