Optimize Page#dir with a private method #8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Dec 2, 2020
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Dec 2, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
Ashwin Maroli: Optimize Page#dir with a private method (#8489) Merge pull request 8489
github-actions bot
pushed a commit
to tigefa4u/jekyll
that referenced
this pull request
Dec 2, 2020
jekyllbot: Update history to reflect merge of jekyll#8489 [ci skip]
github-actions bot
pushed a commit
to patilswapnilv/jekyll
that referenced
this pull request
Dec 2, 2020
jekyllbot: Update history to reflect merge of jekyll#8489 [ci skip]
github-actions bot
pushed a commit
to patilswapnilv/jekyll
that referenced
this pull request
Dec 2, 2020
jekyllbot: Update history to reflect merge of jekyll#8489 [ci skip]
github-actions bot
pushed a commit
to chauncey-garrett/jekyll
that referenced
this pull request
Dec 2, 2020
jekyllbot: Update history to reflect merge of jekyll#8489 [ci skip]
github-actions bot
pushed a commit
to chauncey-garrett/jekyll
that referenced
this pull request
Dec 2, 2020
jekyllbot: Update history to reflect merge of jekyll#8489 [ci skip]
This was referenced Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the same boat as #8485, because
Jekyll::Page#to_liquidisn't memoized,Jekyll::Page#dirget called for every call to#to_liquid.Unfortunately,
#dircan't be directly memoized either because@diris already defined inJekyll::Page#initializeand has different semantics in comparison to the result from calling#dir. Using a new instance variable name is risky becauseJekyll::Pageis a popular ancestor for Generator based plugins.Therefore, move the allocating logic into a new private and memoized method.