Reduce allocations from computing item property #8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Third-party Profiling Summary--- master https://github.com/jekyll/jekyll/runs/1469611301
+++ PR https://github.com/jekyll/jekyll/runs/1470442250
- done in 49.315 seconds.
- done in 50.467 seconds.
- done in 50.72 seconds.
+ done in 29.244 seconds.
+ done in 30.09 seconds.
+ done in 30.28 seconds.
- Total allocated: 2.32 GB (4820149 objects)
- Total retained: 46.63 MB (127078 objects)
+ Total allocated: 433.99 MB (1926164 objects)
+ Total retained: 45.91 MB (126642 objects) |
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Dec 2, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
Ashwin Maroli: Reduce allocations from computing item property (#8485) Merge pull request 8485
github-actions bot
pushed a commit
to tigefa4u/jekyll
that referenced
this pull request
Dec 2, 2020
jekyllbot: Update history to reflect merge of jekyll#8485 [ci skip]
This was referenced Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
:to_liquidmethod forConvertibleobjects (mainlyJekyll::Pageand subclasses) is not memoized. Therefore, callingJekyll::Page#to_liquidmultiple times results in unnecessary Hash allocations.This change optimizes iteration through
site.pageswhenitem_propertyof each page is computed.Possible use-cases
Filtering
site.pageswith either ofsort,where,findfilters multiple times.