Explicitly return nil after site process phase #8472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jekyllbot: merge +bug |
jekyllbot
added a commit
that referenced
this pull request
Nov 18, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2020
Ashwin Maroli: Explicitly return nil after site process phase (#8472) Merge pull request 8472
This was referenced Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The various phases within
site.processhasReturns nothing.in the Ruby code documentation.Yet, those phases when called individually returns something other than nothing.
This pull request fixes above by explicitly returning
nil.Context
When toying with the site build process phases via IRB, various phases may output large amount of data in site with numerous pages and documents.